Use default_factory for mutable dataclass default #43
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamaro
requested review from
calebho,
giongto35,
jj10306 and
luccabb
as code owners
itamaro
added a commit
to itamaro/gcm
that referenced
this pull request
Feb 10, 2026
Summary: Python 3.12 strictly enforces that dataclass fields with mutable defaults (including other dataclass instances) must use field(default_factory=...) instead of direct assignment. Changed the ApplicationClockInfo default to use a lambda factory. Reviewed By: drinkmorewaterr Differential Revision: D92669096
itamaro
force-pushed
the
export-D92669096
branch
from
1399bc1 to
c884e45
Compare
Summary: Python 3.12 strictly enforces that dataclass fields with mutable defaults (including other dataclass instances) must use field(default_factory=...) instead of direct assignment. Changed the ApplicationClockInfo default to use a lambda factory. Reviewed By: drinkmorewaterr Differential Revision: D92669096
itamaro
force-pushed
the
export-D92669096
branch
from
c884e45 to
5fbd4d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Python 3.12 strictly enforces that dataclass fields with mutable defaults (including other dataclass instances) must use field(default_factory=...) instead of direct assignment. Changed the ApplicationClockInfo default to use a lambda factory.
Differential Revision: D92669096