fix unexpected ValueError #1270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When value is a numpy array, comparing a numpy array with None object will give another numpy array. Then a ValueError will be raised, says: ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all(). For example, you can test this funtion with value = numpy.array([1,2,3]), and default=None.
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When value is a numpy array, comparing a numpy array with None object will give another numpy array. Then a ValueError will be raised, says: ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all(). For example, you can test this funtion with value = numpy.array([1,2,3]), and default=None.
Thanks for your contribution!
If you're sending a large PR (e.g., >50 lines), please open an issue first about
the feature/bug, and indicate how you want to contribute.
Use contributing guidelines before opening up the PR to follow MMF style guidelines.