Conversation
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D87682390. (Because this pull request was imported automatically, there will not be any future comments.) |
3604ece to
7619393
Compare
5de743f to
0924e15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit address an issue where executing
test_nvdec_decode_crop_resizebeforetest_nvdec_decode_h264_420p_cropcauses the latter to return wrong resultsdue to bad state left behind.
The fix involves modifying theNvDecDecoderCore::reset()method to properly clean up state,including resetting crop, target width and height, and source information to default values.
This ensures that the thread-local cached decoder does not carry over stale parameters from previous test runs.
Modifying the
NvDecDecoderCoreis more elaborated, so, for now, we disable cache if crop is provided.This commit also adds the stand alone test that would repro the issue without the patch.Moved to #1186 as the test manifests a different issue.
Closes #1159