Override num_workers from 0 to 1 in get_pytorch_dataloader
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68357865 |
mthrok
reviewed
Jan 18, 2025
| raise ValueError(f"`num_workers` must be greater than 0. Found: {num_workers}") | ||
| elif num_workers == 0: | ||
| _LG.warning( |
There was a problem hiding this comment.
Could you use warnings.warn with stack_level=2?
There was a problem hiding this comment.
This is a good explanation of which one to use.
There was a problem hiding this comment.
Thanks for the resource! I just updated the code to reflect this
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Jan 22, 2025
…ookresearch#330) Summary: To support a similar interface to the pytorch dataloader, we set `num_workers` to 1 if the input `num_workers` is 0 in `get_pytorch_dataloader` Differential Revision: D68357865
vbourgin
force-pushed
the
export-D68357865
branch
from
2cdaf42 to
a32ac35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68357865 |
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Jan 22, 2025
…ookresearch#330) Summary: To support a similar interface to the pytorch dataloader, we set `num_workers` to 1 if the input `num_workers` is 0 in `get_pytorch_dataloader` Differential Revision: D68357865
vbourgin
force-pushed
the
export-D68357865
branch
from
a32ac35 to
7c39d28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68357865 |
|
Looks good. Thanks. |
vbourgin
pushed a commit
to vbourgin/spdl
that referenced
this pull request
Jan 22, 2025
…ookresearch#330) Summary: To support a similar interface to the pytorch dataloader, we set `num_workers` to 1 if the input `num_workers` is 0 in `get_pytorch_dataloader` Reviewed By: moto-meta Differential Revision: D68357865
vbourgin
force-pushed
the
export-D68357865
branch
from
7c39d28 to
f7892fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68357865 |
mthrok
approved these changes
Jan 22, 2025
…ookresearch#330) Summary: To support a similar interface to the pytorch dataloader, we set `num_workers` to 1 if the input `num_workers` is 0 in `get_pytorch_dataloader` Reviewed By: moto-meta Differential Revision: D68357865
vbourgin
force-pushed
the
export-D68357865
branch
from
f7892fa to
51da1b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68357865 |
facebook-github-bot
merged commit ca1389a
into
facebookresearch:main
17 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: To support a similar interface to the pytorch dataloader, we set
num_workersto 1 if the inputnum_workersis 0 inget_pytorch_dataloaderDifferential Revision: D68357865