Fix bug with variants overriding existing configuration

factorial-io · May 28, 2019 · 601e5b7 · 601e5b7
1 parent 0639321
commit 601e5b7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Configuration/BlueprintConfiguration.php b/src/Configuration/BlueprintConfiguration.php
@@ -86,7 +86,13 @@ public function expandVariants($blueprints)
         foreach ($blueprints as $data) {
             $template = $this->getTemplate($data['configName']);
             foreach ($data['variants'] as $variant) {
-                $this->configuration->addHost($template->expand($variant));
+                $host = $template->expand($variant);
+                if (!$this->configuration->hasHostConfig($host['configName'])) {
+                    $this->configuration->addHost($template->expand($variant));
+                }
+                else {
+                  $this->configuration->getLogger()->notice('There\'s an existing config with that name, skipping creating one from blueprint');
+                }
             }
         }
     }

diff --git a/src/Configuration/ConfigurationService.php b/src/Configuration/ConfigurationService.php
@@ -710,4 +710,8 @@ protected function inheritFromBlueprint(string $config_name, $data): array
 
         return $data;
     }
+
+  public function hasHostConfig($configName) {
+      return !empty($this->hosts[$configName]);
+  }
 }