fix(profile): Load Profile Effect

* revised loadProfile NgRx effect to handle errors on a per-request basis and still get results for the successful requests.
faizanalibugti · Dec 31, 2023 · 074a623 · 074a623
1 parent 5bc3442
commit 074a623
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 8 deletions.
diff --git a/apps/filmpire/src/app/+state/profile/profile.effects.ts b/apps/filmpire/src/app/+state/profile/profile.effects.ts
@@ -47,16 +47,54 @@ export class ProfileEffects {
       filter(({ sessionId }) => !!sessionId),
       concatMap(({ user, sessionId }) =>
         forkJoin({
-          favoriteMovies: this.accountHttp.getFavoriteMovies(
-            user.id,
-            sessionId
+          favoriteMovies: this.accountHttp
+            .getFavoriteMovies(user.id, sessionId)
+            .pipe(
+              catchError((error) => {
+                // Handle error for getFavoriteMovies
+                return of({
+                  page: 0,
+                  total_pages: 0,
+                  total_results: 0,
+                  results: [],
+                });
+              })
+            ),
+          favoriteTV: this.accountHttp.getFavouriteTV(user.id, sessionId).pipe(
+            catchError((error) => {
+              // Handle error for getFavoriteMovies
+              return of({
+                page: 0,
+                total_pages: 0,
+                total_results: 0,
+                results: [],
+              });
+            })
           ),
-          favoriteTV: this.accountHttp.getFavouriteTV(user.id, sessionId),
-          watchListMovies: this.accountHttp.getWatchListMovies(
-            user.id,
-            sessionId
+          watchListMovies: this.accountHttp
+            .getWatchListMovies(user.id, sessionId)
+            .pipe(
+              catchError((error) => {
+                // Handle error for getFavoriteMovies
+                return of({
+                  page: 0,
+                  total_pages: 0,
+                  total_results: 0,
+                  results: [],
+                });
+              })
+            ),
+          watchListTV: this.accountHttp.getWatchListTV(user.id, sessionId).pipe(
+            catchError((error) => {
+              // Handle error for getFavoriteMovies
+              return of({
+                page: 0,
+                total_pages: 0,
+                total_results: 0,
+                results: [],
+              });
+            })
           ),
-          watchListTV: this.accountHttp.getWatchListTV(user.id, sessionId),
         }).pipe(
           map((profileData: ProfileData) =>
             ProfileActions.profileApiActions.loadProfileSuccess({

diff --git a/apps/filmpire/src/app/account/account.component.html b/apps/filmpire/src/app/account/account.component.html
@@ -98,4 +98,5 @@ <h2 class="mb-10 text-3xl font-semibold dark:text-white">
     No items to show. Please add a media to either favorite or watchlist for the
     item to appear here
   </p>
+  <br/>
 </ng-template>