infra(unicorn): no-await-expression-member (#2812)

faker-js · Apr 21, 2024 · 81d0718 · 81d0718
1 parent b27d4fc
commit 81d0718
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -51,7 +51,6 @@ module.exports = defineConfig({
     'unicorn/better-regex': 'off',
     'unicorn/consistent-function-scoping': 'off',
     'unicorn/import-style': 'off',
-    'unicorn/no-await-expression-member': 'off',
     'unicorn/no-object-as-default-parameter': 'off',
     'unicorn/numeric-separators-style': 'off',
     'unicorn/prefer-export-from': 'off',

diff --git a/scripts/generate-locales.ts b/scripts/generate-locales.ts
@@ -338,9 +338,7 @@ async function normalizeLocaleFile(filePath: string, definitionKey: string) {
 
   console.log(`Running data normalization for:`, filePath);
 
-  const fileContent = (
-    await readFile(filePath, { encoding: 'utf8' })
-  ).toString();
+  const fileContent = await readFile(filePath, { encoding: 'utf8' });
   const searchString = 'export default ';
   const compareIndex = fileContent.indexOf(searchString) + searchString.length;
   const compareString = fileContent.substring(compareIndex);

diff --git a/test/faker.spec.ts b/test/faker.spec.ts
@@ -18,7 +18,8 @@ describe('faker', () => {
       .filter((key) => typeof console[key] === 'function')
       .map((methodName) => vi.spyOn(console, methodName));
 
-    (await import('..')).default;
+    const file: unknown = await import('..');
+    expect(file).toBeDefined();
 
     new Faker({ locale: { metadata: { title: '' } } });