Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernise buzz- and catch-phrases #2929

Closed
matthewmayer opened this issue May 28, 2024 · 0 comments · Fixed by #2930
Closed

Modernise buzz- and catch-phrases #2929

matthewmayer opened this issue May 28, 2024 · 0 comments · Fixed by #2930
Labels
c: locale Permutes locale definitions good first issue Good for newcomers help wanted Extra attention is needed m: company Something is referring to the company module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented May 28, 2024 •
edited
Loading

Extracted from discussion at #2921 (comment)

Some of the phrases in company/buzz_adjective etc feel quite dated, using early 2000s Web 2.0/dot-com bubble language.

Some outdated phrases could be removed and replaced with more modern phrases.
@matthewmayer matthewmayer changed the title Modernise buzz phrases Modernise buzz- and catch-phrases May 28, 2024
matthewmayer added a commit to matthewmayer/faker that referenced this issue May 28, 2024
@matthewmayer
feat(company): Modernise buzz- and catch-phrases
77b3eb1 
fix faker-js#2929
@matthewmayer matthewmayer mentioned this issue May 28, 2024
Merged
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels May 28, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 28, 2024
@xDivisionByZerox xDivisionByZerox added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: locale Permutes locale definitions good first issue Good for newcomers help wanted Extra attention is needed m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

refactor(locale): modernise buzz- and catch-phrases matthewmayer/faker
3 participants
@matthewmayer @ST-DDT @xDivisionByZerox