-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): modernise buzz- and catch-phrases #2930
refactor(locale): modernise buzz- and catch-phrases #2930
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2930 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2798 2798
Lines 227380 227335 -45
Branches 582 956 +374
==========================================
- Hits 227320 227270 -50
- Misses 60 65 +5
|
Lools good to me maybe throw these also in there:
|
Maybe ask an LLM for more modern buzz words. |
From ChatGPT: Innovative |
I did already use ChatGPT to help identify which words sounded most outdated and propose a few more. I'll try to top up with some additional ones so the overall number of words stays roughly the same. |
@matthewmayer Could you please complete this PR? |
im actually fairly happy with current state of the PR. Don't want to add it too many words at the moment, because its not always clear which new words will actually stand the test of time, and which will become quickly dated. Focus is mostly on removing the very outdated terms, and i think there's still plenty of remaining definitions that we dont need to add too many. |
fix #2929