Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): modernise buzz- and catch-phrases #2930

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented May 28, 2024

fix #2929

Copy link

netlify bot commented May 28, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 20f5959
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67115dd10ceb3600084209ae
😎 Deploy Preview https://deploy-preview-2930.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (858f8d0) to head (20f5959).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2930      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2798     2798              
  Lines      227380   227335      -45     
  Branches      582      956     +374     
==========================================
- Hits       227320   227270      -50     
- Misses         60       65       +5     
Files with missing lines Coverage Δ
src/locales/en/company/adjective.ts 100.00% <100.00%> (ø)
src/locales/en/company/buzz_adjective.ts 100.00% <100.00%> (ø)
src/locales/en/company/buzz_noun.ts 100.00% <100.00%> (ø)
src/locales/en/company/buzz_verb.ts 100.00% <100.00%> (ø)
src/locales/en/company/descriptor.ts 100.00% <100.00%> (ø)
src/locales/en/company/noun.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@matthewmayer matthewmayer marked this pull request as ready for review May 28, 2024 03:53
@matthewmayer matthewmayer requested a review from a team as a code owner May 28, 2024 03:53
@ST-DDT
Copy link
Member

ST-DDT commented May 28, 2024

Lools good to me maybe throw these also in there:

  • solar powered
  • heat pump
  • cloud
  • cloud driven
  • secure
  • relyable
  • scaleable
  • redundant
  • powerful
  • consumer-driven
  • autonomous
  • self learning
  • smart home device

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels May 28, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 28, 2024
@ST-DDT
Copy link
Member

ST-DDT commented May 28, 2024

Maybe ask an LLM for more modern buzz words.

@ShaharIlany
Copy link
Contributor

Maybe ask an LLM for more modern buzz words.

From ChatGPT:

Innovative
Hyper-scalable
Agile
Dynamic
Sustainable
Visionary
Seamless
AI-powered
Data-driven
Cloud-native
Scalable

@matthewmayer
Copy link
Contributor Author

I did already use ChatGPT to help identify which words sounded most outdated and propose a few more.

I'll try to top up with some additional ones so the overall number of words stays roughly the same.

@ST-DDT ST-DDT marked this pull request as draft May 30, 2024 16:03
@ST-DDT
Copy link
Member

ST-DDT commented Oct 16, 2024

@matthewmayer Could you please complete this PR?

@ST-DDT ST-DDT changed the title feat(company): Modernise buzz- and catch-phrases refactor(locale): modernise buzz- and catch-phrases Oct 16, 2024
@matthewmayer matthewmayer marked this pull request as ready for review October 17, 2024 02:16
@matthewmayer
Copy link
Contributor Author

im actually fairly happy with current state of the PR. Don't want to add it too many words at the moment, because its not always clear which new words will actually stand the test of time, and which will become quickly dated. Focus is mostly on removing the very outdated terms, and i think there's still plenty of remaining definitions that we dont need to add too many.

@ST-DDT ST-DDT requested review from a team October 17, 2024 07:37
@xDivisionByZerox xDivisionByZerox enabled auto-merge (squash) October 17, 2024 18:56
@xDivisionByZerox xDivisionByZerox merged commit 247c86f into faker-js:next Oct 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modernise buzz- and catch-phrases
5 participants