-
-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: enable no-useless-escape eslint rule #2434
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2434 +/- ##
=======================================
Coverage 99.57% 99.58%
=======================================
Files 2823 2823
Lines 255523 255523
Branches 1098 1103 +5
=======================================
+ Hits 254449 254468 +19
+ Misses 1046 1027 -19
Partials 28 28
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is acutally pretty cool. I always forget which characters to escape and default to simply ascaping all symbols. This lets me know while coding without having to look it up additionally. I like that.
This lint rule is likely to be enabled/"covered" by eslint rule
unicorn/better-regex
after #2418 is merged.This PR is independent of that PR though.