-
-
Notifications
You must be signed in to change notification settings - Fork 980
feat(music): add album and artist methods #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xDivisionByZerox
merged 17 commits into
faker-js:next
from
jeremyhofer:music-artist-album-new-genres-songs
Apr 29, 2024
Merged
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
1a58eb8
feat(music): add albumName and artist methods add additional genres a…
jeremyhofer d4f7975
properly sort album and artist lists. update snapshot
jeremyhofer e8d2ab4
Merge branch 'next' into music-artist-album-new-genres-songs
matthewmayer de48000
fix typo. cleanup blatantly profane album names. cleanup non-ascii ba…
jeremyhofer b7f3f99
prune additional artists and albums. case insensitive sort sets
jeremyhofer d4d2b29
Merge branch 'next' into music-artist-album-new-genres-songs
ST-DDT 29122a1
chore: apply suggestions from code review
xDivisionByZerox 9ee4ec7
Merge branch 'next' into pr/jeremyhofer/2620
xDivisionByZerox 01b3ed9
refactor: shorten function names
xDivisionByZerox b1b7f81
docs: fix broken links
xDivisionByZerox 5e2cee0
docs: fix incorrect method name reference
xDivisionByZerox f7c78a9
refactor: remove name suffix from definitions
xDivisionByZerox f2294f0
revert: changes to song/songName
xDivisionByZerox 3d1dd46
test: update snapshot
xDivisionByZerox bc1ffe9
Merge branch 'next' into music-artist-album-new-genres-songs
xDivisionByZerox a5e9958
refactor: normalize locale data
xDivisionByZerox 65c11e9
test: update snapshots
xDivisionByZerox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.