-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(internet): add Hebrew username charMapping #2781
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2781 +/- ##
=======================================
Coverage ? 99.93%
=======================================
Files ? 2973
Lines ? 212561
Branches ? 602
=======================================
Hits ? 212420
Misses ? 137
Partials ? 4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to automatically fix it with: pnpm run lint --fix
Here's 100 outputs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, the resulting emails look better than before. they are a bit short on vowels, but that's just how Hebrew works
instead of getting such a result
15t15q15f160.15c15l16215r@hotmail.com
Following #2776