Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: ignore vitest temp config #3199

Merged
merged 2 commits into from
Oct 23, 2024
Merged

infra: ignore vitest temp config #3199

merged 2 commits into from
Oct 23, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 20, 2024

Vitest creates a temp config tsconfig.vitest-temp.json while it is running.
This can easily be checked in and commited by accident.

This PR adds it to the .gitignore list to prevent that issue in the future.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test c: infra Changes to our infrastructure or project setup labels Oct 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 20, 2024
@ST-DDT ST-DDT requested review from a team October 20, 2024 15:42
@ST-DDT ST-DDT self-assigned this Oct 20, 2024
Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 268c076
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6718efb42c49960007b54ef5
😎 Deploy Preview https://deploy-preview-3199.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (7847ee9) to head (268c076).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3199      +/-   ##
==========================================
+ Coverage   99.95%   99.97%   +0.01%     
==========================================
  Files        2796     2796              
  Lines      216704   216704              
  Branches      948      959      +11     
==========================================
+ Hits       216605   216645      +40     
+ Misses         99       59      -40     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team October 22, 2024 18:30
@ST-DDT ST-DDT enabled auto-merge (squash) October 23, 2024 12:42
@ST-DDT ST-DDT merged commit a03378b into next Oct 23, 2024
23 checks passed
@ST-DDT ST-DDT deleted the test/ignore-temp-config branch October 23, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup c: test p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants