Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(renovate): reduce update frequency to monthly #3217

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 23, 2024

Fixes #3077


It looks like most team members are busy with other tasks, so we should reduce the frequency of dependency updates to avoid notification spam.A list of available updates is still available in the dependency dashboard issue.

This PR set the dependency update schedule to monthly (1st each month).

Alternative solutions:

  • Set prCreation to 'approval' (via dependency dashboard checkbox)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: dependencies Pull requests that adds/updates a dependency s: needs decision Needs team/maintainer decision c: infra Changes to our infrastructure or project setup labels Oct 23, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 23, 2024
@ST-DDT ST-DDT requested review from a team October 23, 2024 14:24
@ST-DDT ST-DDT self-assigned this Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 25f6e1f
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/671cee8db7794e0008682b42
😎 Deploy Preview https://deploy-preview-3217.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (8bceb58) to head (25f6e1f).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3217      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2804     2804              
  Lines      216974   216974              
  Branches      962      577     -385     
==========================================
- Hits       216894   216887       -7     
- Misses         80       87       +7     

see 2 files with indirect coverage changes

@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Oct 26, 2024
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 26, 2024

Team Decision

Faker only has dev dependencies, so updates aren't critical to our users.
With our current release frequency it is sufficient to do the updates before we release.
We stick to monthly updates to get notified of breaking changes frequently/monthly.

@ST-DDT ST-DDT enabled auto-merge (squash) October 26, 2024 13:28
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Oct 26, 2024
@ST-DDT ST-DDT merged commit 975098d into next Oct 26, 2024
24 checks passed
@ST-DDT ST-DDT deleted the infra/renovate/schedule-monthly branch October 26, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce frequency of dependency update PRs
4 participants