Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): en_AU state postcode definitions #3219

Closed

Conversation

ProxiBlue
Copy link

Add in en_AU localisation for state postcodes

Add in en_AU localisation for state postcodes
@ProxiBlue ProxiBlue requested a review from a team as a code owner October 24, 2024 12:43
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for fakerjs failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 02053bb
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/671ac6169a4fe70008c927cc

@@ -1 +1,34 @@
export default ['####'];
export default {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct location. Needs to be in a seperate file. Check the en-us locale for an example.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I completely missed that. In the US example, teh default postcode.ts file does not exist.
Is that correct? I must remove the file, or leave it as a default?

I figure remove, as AU cannot have a random 'default' value. states must match postcodes else form validation may fail.

Copy link
Author

@ProxiBlue ProxiBlue Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, ok, no I have more issues:

[Unhandled error: src/locales/en_AU/location/index.ts#L17](https://github.com/faker-js/faker/pull/3219/files#annotation_27826361785)
TypeCheckError: Type '{ NSW string[]; ACT string[]; VIC string[]; QLD string[]; SA string[]; WA string[]; TAS string[]; NT string[]; }' is not assignable to type 'string | string[] | null | undefined'.
 ❯ src/locales/en_AU/location/index.ts:17:3

I will pull PR for now, and get it properly sorted. Just a bit busy. thought it was a quick drop a file in PR, sine I was busy with tests in this section.

Will get back to this later, more urgent work to get done

@ST-DDT ST-DDT added this to the vAnytime milestone Oct 24, 2024
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Oct 24, 2024
@ProxiBlue ProxiBlue closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants