Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(finance): add seeAlsos #3344

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

docs(finance): add seeAlsos #3344

wants to merge 2 commits into from

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 28, 2024

The amount, accountNumber, pin methods are basically aliases to their string/number counterparts.

This PR adds @see links to their jsdocs to provide alternatives if more generation options/control is needed.

Preview

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Dec 28, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 28, 2024
@ST-DDT ST-DDT requested review from a team December 28, 2024 15:20
@ST-DDT ST-DDT self-assigned this Dec 28, 2024
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit dfb81dc
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67701729c603c800083b40a4
😎 Deploy Preview https://deploy-preview-3344.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (e6d27a3) to head (dfb81dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3344      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2811     2811              
  Lines      217017   217017              
  Branches      941      942       +1     
==========================================
- Hits       216966   216964       -2     
- Misses         51       53       +2     
Files with missing lines Coverage Δ
src/modules/finance/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant