Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 9.4.0 #3362

Merged
merged 1 commit into from
Jan 15, 2025
Merged

chore(release): 9.4.0 #3362

merged 1 commit into from
Jan 15, 2025

Conversation

fakerjs-bot
Copy link
Collaborator

@fakerjs-bot fakerjs-bot commented Jan 2, 2025

Release for 9.4.0

  • Completed manual changes/tasks for this release

@ST-DDT ST-DDT self-assigned this Jan 2, 2025
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit be57714
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/678779fb1aed8a0008e6e65c
😎 Deploy Preview https://deploy-preview-3362.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: release Release labels Jan 2, 2025
@ST-DDT ST-DDT added this to the v9.x milestone Jan 2, 2025
ST-DDT
ST-DDT previously approved these changes Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (773fc1f) to head (be57714).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3362      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2811     2811              
  Lines      217035   217035              
  Branches      942      939       -3     
==========================================
- Hits       216984   216982       -2     
- Misses         51       53       +2     

see 1 file with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Jan 2, 2025

Blocked by #3343

Currently, the script uses the version of the package.json to download the faker bins. However, since the new version hasn't been released yet, it cannot do so, failing the CI.

@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Jan 2, 2025
@ST-DDT ST-DDT dismissed their stale review January 2, 2025 19:40

Release <-> CI circular dependency

@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Jan 13, 2025
@ST-DDT ST-DDT marked this pull request as ready for review January 13, 2025 15:24
@ST-DDT ST-DDT requested a review from a team as a code owner January 13, 2025 15:24
ST-DDT
ST-DDT previously approved these changes Jan 13, 2025
@ST-DDT ST-DDT requested review from a team January 13, 2025 15:26
@ST-DDT
Copy link
Member

ST-DDT commented Jan 13, 2025

Ready for review

@ST-DDT ST-DDT merged commit 192b540 into next Jan 15, 2025
24 checks passed
@ST-DDT ST-DDT deleted the chore/release/9.4.0 branch January 15, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: release Release p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants