Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix finance.iban warnings #781

Merged
merged 2 commits into from
Apr 5, 2022
Merged

chore: fix finance.iban warnings #781

merged 2 commits into from
Apr 5, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Apr 5, 2022

Ref: #541

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Apr 5, 2022
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Apr 5, 2022
@ST-DDT ST-DDT requested review from a team April 5, 2022 20:36
@ST-DDT ST-DDT self-assigned this Apr 5, 2022
@ST-DDT ST-DDT mentioned this pull request Apr 5, 2022
Closed
@Shinigami92 Shinigami92 requested a review from a team April 5, 2022 20:44
@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #781 (b7bc8b7) into main (c6d0cc7) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head b7bc8b7 differs from pull request most recent head d4c351c. Consider uploading reports for the commit d4c351c to get more accurate results

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   99.34%   99.34%   -0.01%     
==========================================
  Files        1921     1921              
  Lines      176644   176516     -128     
  Branches      905      909       +4     
==========================================
- Hits       175491   175363     -128     
  Misses       1097     1097              
  Partials       56       56
Impacted Files Coverage Δ
src/iban.ts 100.00% <100.00%> (ø)
src/lorem.ts 100.00% <0.00%> (ø)
src/definitions/address.ts 100.00% <0.00%> (ø)
src/locales/ar/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/az/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/cz/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/de/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/en/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/fr/address/street_address.ts 100.00% <0.00%> (ø)
src/locales/ge/address/street_address.ts 100.00% <0.00%> (ø)
... and 24 more

pkuczynski
pkuczynski reviewed Apr 5, 2022
View reviewed changes
src/iban.ts Show resolved Hide resolved
pkuczynski
pkuczynski requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@pkuczynski pkuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in mod97 needs to be clarified...

@ST-DDT ST-DDT enabled auto-merge (squash) April 5, 2022 22:26
@ST-DDT ST-DDT merged commit 46b2bd4 into main Apr 5, 2022
@ST-DDT ST-DDT deleted the chore/finance/iban-fix-warnings branch April 5, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.
3 participants
@ST-DDT @pkuczynski @Shinigami92