Skip to content

Commit

Permalink
chore(tests/asgi): do not check ASGI server retcode on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
vytas7 committed Mar 20, 2024
1 parent ef68b8f commit 0610706
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/asgi/test_asgi_servers.py
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,10 @@ def server_base_url(request):
# NOTE(vytas): Starting with 0.29.0, Uvicorn will propagate signal
# values into the return code (which is a good practice in Unix);
# see also https://github.com/encode/uvicorn/pull/1600
assert server.returncode in (0, -signal.SIGTERM)
# TODO(vytas): Return codes are bananas on Windows, skip for now;
# is there a reliable way to know which code to expect?
if not _WIN32:
assert server.returncode in (0, -signal.SIGTERM)

break

Expand Down

0 comments on commit 0610706

Please sign in to comment.