-
-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WebSocket): handle OSError
upon send()
+ fix max_receive_queue == 0
#2324
Conversation
Note that I still need to revise the wording of our WebSocket docs, hence Draft (for now). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2324 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 7522 7539 +17
Branches 1275 1281 +6
=========================================
+ Hits 7522 7539 +17 ☔ View full report in Codecov by Sentry. |
OSError
upon send()
OSError
upon send()
+ fix max_receive_queue == 0
I'm waiting for this to exit draft. let me know if I should review before then |
Thanks @CaselIT , I haven't had much time to work on this, there are a couple of items remaining. Code-wise (not tests) I am not planning any more changes, so time permitting you could take a look at that part. I need to add more tests, and morph newsfragments. |
@CaselIT maybe this PR is still not perfect (nothing is), but it is IMHO ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, left a suggestion
max_receive_queue == 0
case.test_asgi_servers.py
that exercise themax_receive_queue == 0
case, and catches an error from the webserver'sOSError
uponsend()
.Closes #2292.