-
-
Notifications
You must be signed in to change notification settings - Fork 951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: typing cleanup #2339
chore: typing cleanup #2339
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 64 +1
Lines 7553 7621 +68
Branches 1239 1242 +3
=========================================
+ Hits 7553 7621 +68 ☔ View full report in Codecov by Sentry. |
Not sure if we could provide a |
also customize how generic aliases docs are rendered to avoid adding "alias of <the real type>"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue with coverage.
I'll try to skim through other changes today too.
I believe it's its usual issues, but I haven't checked it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the whole typing effort, this is almost ready to rock.
We just need to address missing coverage, and make a decision on UNSET
before merging.
We could probably bikeshed some names too, but since they are private under _typing
, we can revise them later at any time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now 💯
(Potentially bar naming refinement, but since these are strictly private under _typing
, we can improve them at any time.)
Fixes: #2313
Cannot really came up with many type aliases that may be nice to have public.
For not I've found only 3. https://github.com/falconry/falcon/pull/2339/files#diff-59734eebd58dfd39eafe7094e8725d6d5b3847156d7d0bff3cbdf5095fcf84e4
Also have yet to look at naming.