Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helpers): privatize helper methods intended only for internal use #2341

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Sep 26, 2024

Closes #1457.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (08ee3c0) to head (cae00ed).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2341   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7547      7545    -2     
  Branches      1238      1238           
=========================================
- Hits          7547      7545    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7
Copy link
Member Author

vytas7 commented Sep 26, 2024

(FWIW, I did test Mailman with this just in case.)

@vytas7 vytas7 merged commit f843b4f into falconry:master Sep 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Privatize helpers, etc. that really should only be used internally by the framework
2 participants