Skip to content

feat: type hooks with ParamSpec #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Sep 27, 2024

Follow up of #2344 that types hook with paramspec.

Will merge this after 4.0 is out

@CaselIT CaselIT added this to the Version 4.1 milestone Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b0f7da) to head (2e5931a).
Report is 95 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         7553      7554    +1     
  Branches      1239      1241    +2     
=========================================
+ Hits          7553      7554    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vytas7 vytas7 changed the title Type hooks with parmspec feat: type hooks with ParamSpec Sep 27, 2024
@vytas7
Copy link
Member

vytas7 commented Sep 27, 2024

It is not decided yet whether we want to do this in 4.1, or even further down the road. But we can keep this PR open for a while.

@vytas7 vytas7 removed this from the Version 4.1 milestone Oct 20, 2024
@vytas7
Copy link
Member

vytas7 commented Apr 23, 2025

@CaselIT could you resolve conflicts in this PR in order to focus solely on ParamSpec?
AFAICT we have actually released parts of it in 4.0, for instance, dropped is_async.

I would like to keep runtime compatibility with 3.8, but it seems we can import stuff we need under TYPE_CHECKING, and even use most of the newer syntax under from __future__ import annotations, so it doesn't really conflict with 3.8 runtime support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants