Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RtD): enable PDF build format #2371

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Conversation

AkshayAwate
Copy link
Contributor

Enabled PDF generation on readthedocs.

@vytas7 vytas7 changed the title Enabled pdf build format chore(RtD): enable PDF build format Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f7189d7) to head (22d472b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2371   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7725      7725           
  Branches      1071      1071           
=========================================
  Hits          7725      7725           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AkshayAwate! 👍

Unfortunately, it is hard to test this without actually running it on RtD, but let's merge and see how this fares!

@vytas7 vytas7 merged commit 1bfb819 into falconry:master Oct 19, 2024
31 checks passed
@vytas7
Copy link
Member

vytas7 commented Oct 19, 2024

It is not showed for unstable releases, but it is possible to download just fine, thanks once again!
https://falcon.readthedocs.io/_/downloads/en/latest/pdf/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants