Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(action): no need to checkout #82

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

FedeDP
Copy link
Collaborator

@FedeDP FedeDP commented Feb 9, 2024

No description provided.

…ed out during invocation.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…ad images.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Collaborator Author

FedeDP commented Feb 9, 2024

/hold

@FedeDP
Copy link
Collaborator Author

FedeDP commented Feb 9, 2024

Ok the test worked fine: https://github.com/falcosecurity/libs/actions/runs/7841427978/job/21397737318
Ansible playbooks were found (ie: the repo was actually cloned) and the correct version was used (ie: the provided hash). Workflow failed because it could not find images with provided hash, since it comes from a commit from this PR.

@FedeDP
Copy link
Collaborator Author

FedeDP commented Feb 9, 2024

/unhold

@FedeDP
Copy link
Collaborator Author

FedeDP commented Feb 9, 2024

/cc @therealbobo

@poiana
Copy link

poiana commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Feb 9, 2024
@poiana poiana merged commit 682b58b into main Feb 9, 2024
2 of 3 checks passed
@poiana poiana deleted the chore/action_no_need_to_checkout branch February 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants