return promise from siweConfig.createMessage #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anukul is attempting to deploy a commit to the Aave Team on Vercel. A member of the Team first needs to authorize it. |
|
cc @lochie |
lochie
requested changes
Feb 15, 2024
| @@ -21,7 +21,7 @@ export type SIWEConfig = { | |||
| nonce: string; | |||
| address: string; | |||
| chainId: number; | |||
| }) => string; | |||
| }) => Promise<string>; | |||
There was a problem hiding this comment.
This should allow for both string | Promise<string> to avoid breaking changes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lochie
added a commit
that referenced
this pull request
Jun 4, 2024
|
adding support for this in #387 |
lochie
added a commit
that referenced
this pull request
Jun 5, 2024
* viem siwe * wagmi fix * cleanup * handle all chains * use parseSiweMessage * types * types * Update package.json * user defined chain * add public client * include type * use config * update packages * bump versions + fix types * update packages * better error information * fix merge * add async support ( #324 ) * versions * Update CHANGELOG.md * bump viem * bump * dep fix * fix testebench * deo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related - #323