Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column block styling #36

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Column block styling #36

merged 4 commits into from
Aug 8, 2024

Conversation

@tonyklapatch tonyklapatch linked an issue Jul 26, 2024 that may be closed by this pull request
Copy link

aem-code-sync bot commented Jul 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Jul 26, 2024

Page Scores Audits Google
/cigars-for-beginners/getting-started PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 33-two-column-layouts July 26, 2024 18:49 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 33-two-column-layouts July 26, 2024 18:52 Inactive
@tonyklapatch
Copy link
Contributor Author

PSI check failure still seems to primarily be from the embed which will be taken care of in a separate ticket.

Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout looks good.

Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic styling looks good.

@codecodeio codecodeio merged commit 132d053 into main Aug 8, 2024
1 of 2 checks passed
@codecodeio codecodeio deleted the 33-two-column-layouts branch August 8, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create two column layouts
3 participants