Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display hero behind nav, remove video summary embed title #56

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Display hero behind nav, remove video summary embed title #56

merged 3 commits into from
Oct 21, 2024

Conversation

tonyklapatch
Copy link
Contributor

Display the hero block behind the nav, vertically center the hero h1 text, add a slight text shadow to the hero h1 for better visibility, and remove the video summary embed title as discussed with Cory.

Fix #54

Test URLs:

@tonyklapatch tonyklapatch linked an issue Oct 18, 2024 that may be closed by this pull request
Fix hero image alignment #54
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 18, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 18, 2024 •
edited
Loading

Page Scores Audits Google
📱 /cigars-for-beginners PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /cigars-for-beginners PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@tonyklapatch
Copy link
Contributor Author

tonyklapatch commented Oct 18, 2024 •
edited
Loading

PSI check has the same TBT mobile issue as the other tickets.

@aem-code-sync aem-code-sync bot temporarily deployed to 54-fix-hero-alignment October 18, 2024 19:58 Inactive
codecodeio
codecodeio approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h1 is centered. hero is aligned as best as it can be until we have the final hero images.

@codecodeio codecodeio merged commit 1aa71ca into main Oct 21, 2024
1 of 2 checks passed
@codecodeio codecodeio deleted the 54-fix-hero-alignment branch October 21, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codecodeio codecodeio codecodeio approved these changes

@bdeffleyfamous bdeffleyfamous Awaiting requested review from bdeffleyfamous

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix hero image alignment
2 participants
@tonyklapatch @codecodeio