Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update zindex #61

Merged
merged 1 commit into from
Oct 28, 2024
Merged

update zindex #61

merged 1 commit into from
Oct 28, 2024

Conversation

bdeffleyfamous
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous commented Oct 25, 2024 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Update z-index to fix overlapping the header.

Fix #60

Test URLs:

@bdeffleyfamous bdeffleyfamous linked an issue Oct 25, 2024 that may be closed by this pull request
wrapper css issue #60
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 25, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Oct 25, 2024

Page Scores Audits Google
📱 /cigars-for-beginners/develop-your-collection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /cigars-for-beginners/develop-your-collection PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

tonyklapatch
tonyklapatch approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@tonyklapatch tonyklapatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outline no longer overlays on top of the header, looks good on desktop and mobile

codecodeio
codecodeio approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@codecodeio codecodeio merged commit 06a181c into main Oct 28, 2024
2 checks passed
@codecodeio codecodeio deleted the 60-wrapper-css-issue branch October 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codecodeio codecodeio codecodeio approved these changes

@tonyklapatch tonyklapatch tonyklapatch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrapper css issue
3 participants
@bdeffleyfamous @codecodeio @tonyklapatch