Remove unused processes #671
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis pull request systematically removes all CSE IMPORT D2CC and CSE IMPORT IDCC service configurations, including Docker Compose definitions, Kubernetes manifests across multiple bases and overlays, Nginx routing rules, gateway route definitions, database initialization scripts, and associated KEDA autoscaling definitions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
README.md (1)
57-58:⚠️ Potential issue | 🟡 MinorDocumentation still references removed process URLs.
Line 58 still lists
http://localhost/cse/import/d2cc/andhttp://localhost/cse/import/idcc/in the available environment URLs, but these processes have been removed per this PR. Consider removing these URLs from the list for consistency.docker-compose/nginx/nginx.conf (1)
408-433:⚠️ Potential issue | 🔴 CriticalAdd missing CSE EXPORT D2CC upstream definitions.
The location blocks at lines 408–433 reference the following upstreams that are not defined in the configuration file:
cse-export-d2cc-gridcapa-upstream(lines 420)cse-export-d2cc-task-manager-server-upstream(lines 423, 429)cse-export-d2cc-job-launcher-server-upstream(line 432)This will cause nginx to fail configuration validation and refuse to start. Either add the missing upstream definitions or remove the CSE EXPORT D2CC location blocks if this section is being deprecated.
🤖 Fix all issues with AI agents
In `@docker-compose/core-valid-day-ahead-conservative/docker-compose.yml`:
- Around line 47-48: The docker-compose service
core-valid-day-ahead-conservative-adapter is pointing to a local test image
(image: test_iva_adapter:latest); update the image entry in docker-compose.yml
to the official registry image (replace test_iva_adapter:latest with the proper
farao/gridcapa-... image name, e.g. farao/gridcapa-adapter or the specific
farao/gridcapa-<adapter>-<tag> used by other services) so the service uses the
canonical farao/gridcapa image and appropriate tag.
- Around line 73-74: The docker-compose service
core-valid-day-ahead-conservative-post-processing currently references a local
test image `test_iva_postproc:latest`; change that image back to the official
registry image (e.g. replace `test_iva_postproc:latest` with the appropriate
`farao/gridcapa-...` image such as `farao/gridcapa-postproc:latest`) so the
service uses the proper `farao/gridcapa-*` image instead of a local test tag.
- Around line 35-36: The docker-compose service
core-valid-day-ahead-conservative-runner is pointing to a local test image
test_iva_app:latest; change the image reference to the official registry naming
used in this repo (replace test_iva_app:latest with the proper farao/gridcapa-*
image for this service, e.g. the matching
farao/gridcapa-core-valid-day-ahead-conservative:latest or the project's
established tag), ensuring the service name
core-valid-day-ahead-conservative-runner uses the canonical farao/gridcapa image
instead of the local test image.
- Around line 18-19: Replace the local test image reference with the canonical
registry image: locate the Docker Compose service named
core-valid-day-ahead-conservative-task-manager and update its image value
(currently test_iva_taskmgr:latest) to the standard repository image (e.g., the
expected farao/gridcapa-* image used across the deployment) so CI/CD and other
developers can pull it; ensure the image tag matches the project's naming
convention and does not point to a local-only test image.
In `@docker-compose/swe-d2cc/docker-compose.yml`:
- Around line 47-48: The docker-compose service swe-d2cc-runner is using an
unqualified local image name "test_logs:latest"; replace it with the canonical
registry image used by other SWE services by setting the image field for
swe-d2cc-runner to "farao/gridcapa-swe-runner:latest" so CI and shared
environments can pull it (update the image value for the swe-d2cc-runner
service).
In `@k8s/overlays/azure/test/kustomization.yaml`:
- Around line 143-146: The YAML block for the swe-idcc runner has the `value`
line over-indented which will break parsing if uncommented; update the commented
block for the container/env under the `swe-idcc-runner` entry so that the `-
name: EXPORT_FAILED_NETWORK` and its `value: "true"` are aligned as sibling
entries under `env` (i.e., reduce the `value` line indentation to match the `-
name:` line), ensuring the `swe-idcc-runner`, `env`, `- name:
EXPORT_FAILED_NETWORK`, and `value` tokens are properly nested.
🧹 Nitpick comments (2)
docker-compose/core-valid-day-ahead-conservative/config/core-valid-day-ahead-conservative-data-bridge-application.yml (1)
14-15: Regex pattern relaxed for VERTICES files - verify intended behavior.The pattern
F320-(.*)-vuses a greedy(.*)that will match any characters betweenF320-and the last-voccurrence. If filenames could contain multiple-vsubstrings, this might match more than intended.Consider using a non-greedy quantifier
(.*?)or a more restrictive character class like([A-Z_]+)if only specific characters are expected betweenF320-and-v.docker-compose/nginx/nginx.conf (1)
540-540: Minor: Stray comment character and inconsistent formatting.Line 540 has an extra
#with excessive whitespace:# # CSE IMPORT EC IDCC section. This should match the formatting of other section comments.✨ Suggested fix
-# # CSE IMPORT EC IDCC section + # CSE IMPORT EC IDCC section
docker-compose/core-valid-day-ahead-conservative/docker-compose.yml
Outdated
Show resolved
Hide resolved
docker-compose/core-valid-day-ahead-conservative/docker-compose.yml
Outdated
Show resolved
Hide resolved
docker-compose/core-valid-day-ahead-conservative/docker-compose.yml
Outdated
Show resolved
Hide resolved
docker-compose/core-valid-day-ahead-conservative/docker-compose.yml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restWhat kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)
Summary by CodeRabbit
Release Notes
Documentation
Bug Fixes
Chores