Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support social verifications for twitter and github #2370

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

CassOnMars
Copy link
Member

@CassOnMars CassOnMars commented Oct 18, 2024

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces support for validating twitter and github usernames in the system. It adds new constants, validation functions, and test cases to ensure username formats comply with specified rules.

Detailed summary

  • Added constants USER_DATA_TYPE_TWITTER and USER_DATA_TYPE_GITHUB in message.proto.
  • Implemented validation functions validateTwitterUsername and validateGithubUsername in validations.ts.
  • Added regex patterns for Twitter and GitHub usernames.
  • Created test cases for Twitter username validation in validations.test.ts.
  • Updated functions to handle new user data types in userDataTypeFromJSON and userDataTypeToJSON across several files.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 54cb864

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 3:27am

@CassOnMars CassOnMars marked this pull request as ready for review October 25, 2024 03:25
@CassOnMars CassOnMars changed the title FIP-199 proposal feat: support social verifications for twitter and github Oct 25, 2024
@CassOnMars CassOnMars added the t-feat Add a new feature or protocol improvement label Oct 25, 2024
@CassOnMars CassOnMars merged commit 913c0f6 into main Oct 25, 2024
8 checks passed
@CassOnMars CassOnMars deleted the cassie-heart/FIP-199 branch October 25, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant