Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add event timestamp metric for event subscription monitoring #2391

Merged

Conversation

aditiharini
Copy link
Contributor

@aditiharini aditiharini commented Oct 29, 2024

This will help us understand if hub are sending events from far back in time.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces an event timestamp metric for monitoring event subscriptions in the EventStreamHubSubscriber class. It enhances the telemetry by adding the earliest event timestamp and associates the metrics with the hub property.

Detailed summary

  • Added a new private property hub to store the hub client host.
  • Extracted the earliest event timestamp using extractEventTimestamp and recorded it with statsd.gauge.
  • Updated existing metrics to include the hub property for better context in monitoring.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: e12b665

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/shuttle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 7:33pm

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 44.18%. Comparing base (1880070) to head (e12b665).
Report is 414 commits behind head on main.

Files with missing lines Patch % Lines
packages/shuttle/src/shuttle/hubSubscriber.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2391       +/-   ##
===========================================
- Coverage   74.05%   44.18%   -29.88%     
===========================================
  Files          99      146       +47     
  Lines        9425    26285    +16860     
  Branches     2097     9310     +7213     
===========================================
+ Hits         6980    11614     +4634     
- Misses       2327    12855    +10528     
- Partials      118     1816     +1698     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aditiharini aditiharini merged commit 9998210 into farcasterxyz:main Oct 29, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant