Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Node.js version and ID Register events #2470

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarsonKotovi4
Copy link

@MarsonKotovi4 MarsonKotovi4 commented Jan 9, 2025

Changes Description

This PR includes the following changes:

  1. Downgrade Node.js version from 22.4.1 to 20.4.1 in Dockerfile.hubble for all build stages
  2. Fix ID Register event type numbering in documentation
  3. Update release process in CONTRIBUTING.md

Change Details

Dockerfile.hubble

  • Downgrade Node.js version from 22.4.1 to 20.4.1 for prune, build, and app stages

onchain_events.md

  • Fixed ID_REGISTER_EVENT_TYPE numbering:
    • REGISTER: from 0 to 1
    • TRANSFER: from 0 to 2
    • CHANGE_RECOVERY: from 0 to 3

CONTRIBUTING.md

  • Improved release steps list formatting
  • Fixed documentation indentation

PR-Codex overview

This PR focuses on updating the onchain_events.md documentation and modifying the Dockerfile.hubble to use a different Node.js version. It also revises the CONTRIBUTING.md file by adjusting the steps for publishing and tagging.

Detailed summary

  • Updated event IDs in onchain_events.md with new values.
  • Changed Node.js version from 22.4.1-slim to 20.4.1-slim in Dockerfile.hubble.
  • Revised steps in CONTRIBUTING.md for clarity and sequence.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 6cc14d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 4:09pm

@MarsonKotovi4 MarsonKotovi4 changed the title fix: update Node.js version and ID Register events PR fix: update Node.js version and ID Register events Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant