Fixfavourites #13
Open
Fixfavourites #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farce1
reviewed
Mar 24, 2021
Comment on lines
24
to
26
| this.router.get(`${this.path}/:userId`, authMiddleware, permissionMiddleware, this.getFavourites); | ||
| this.router.put(`${this.path}/:userId`, authMiddleware, permissionMiddleware, this.addOrRemoveRestaurantToFavourites); | ||
| this.router.get(`${this.path}/:userId`, authMiddleware, this.getFavourites); | ||
| this.router.put(`${this.path}/:userId`, authMiddleware, favourtieEditMiddleware, this.addOrRemoveRestaurantToFavourites); |
Owner
There was a problem hiding this comment.
What's behind permissionMiddleware removal?
| import commentDeleteMiddleware from '../middleware/commentDelete.middleware'; | ||
| import commentEditMiddleware from '../middleware/editComment.middleware'; | ||
|
|
||
| class CommentsController implements Controller { |
Owner
There was a problem hiding this comment.
There is a lot of code that we have to test.
| try { | ||
| selectedComment = await comment.findById(commentId); | ||
| const commentOwner = selectedComment.user !== null && selectedComment.user; | ||
| if ( userRole === 2) { |
Owner
There was a problem hiding this comment.
Suggested change
| if ( userRole === 2) { | |
| if ( userRole === userRoles.User) { |
We have to make a map that will hold these numeric values
| try { | ||
| const favourieListtId = request.params.userId; | ||
| const userId = request.user._id; | ||
| if ( userId.toString() !== favourieListtId.toString() ) { |
Owner
There was a problem hiding this comment.
favourieListtId -misspeled
userId.toString() !== favourieListtId.toString() - this can be extracted to const
Closed
farce1
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add middleware