Skip to content

Added the ability to center text using android.view.Gravity.#219

Open
ABIvan-Tech wants to merge 2 commits intofaruktoptas:masterfrom
ABIvan-Tech:master
Open

Added the ability to center text using android.view.Gravity.#219
ABIvan-Tech wants to merge 2 commits intofaruktoptas:masterfrom
ABIvan-Tech:master

Conversation

@ABIvan-Tech
Copy link
Copy Markdown

Added the ability to center text using android.view.Gravity.
Added example of using this function

@faruktoptas
Copy link
Copy Markdown
Owner

faruktoptas commented Mar 30, 2021

Hi @alex-soft-r
There's already a gravity implementation. Why is this needed?
titleStyle(0, Gravity.BOTTOM or Gravity.CENTER)

@ABIvan-Tech
Copy link
Copy Markdown
Author

This implementation does not work correctly. For example, we cannot set the bottom-left gravity for the title text.
Please see my example in SecondActivity

@ABIvan-Tech
Copy link
Copy Markdown
Author

Any news?

import me.toptas.fancyshowcase.internal.SharedPrefImpl
import me.toptas.fancyshowcase.internal.getStatusBarHeight
import me.toptas.fancyshowcase.ext.*
import me.toptas.fancyshowcase.internal.*
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if its a style thing but at my work we usually don't allow blanket * for the whole class. Not sure of this repos style guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants