Skip to content

Pd 251120 gkfix#5

Merged
GedasKr merged 3 commits intomasterfrom
PD_251120_GKFIX
Nov 20, 2025
Merged

Pd 251120 gkfix#5
GedasKr merged 3 commits intomasterfrom
PD_251120_GKFIX

Conversation

@GedasKr
Copy link
Contributor

@GedasKr GedasKr commented Nov 20, 2025

Description

This PR implements the Custom Logo Feature, allowing administrators to replace the default Fast.BI logo with a custom company logo globally across the console.

Key Features:

  1. Upload Mechanism: Administrators can upload a new logo by clicking and holding the main logo for 15 seconds. This triggers a hidden upload modal.
  2. Persistence: The uploaded logo is saved to the instance/ directory and persists across sessions (assuming persistent storage is configured for the container).
  3. Flicker-Free Loading: Implemented a backend context processor to inject the correct logo path (/ui-config/custom_logo or default) directly into the HTML templates at render time, ensuring no visual flicker occurs during page navigation.
  4. Security: The upload endpoint (/ui-config/upload_logo) is protected and only accessible to users in the Admin or consoleAdmin groups.

Technical Details:

  • Backend: Added Flask endpoints for upload and serving. Updated app.py with a context processor for logo_path.
  • Frontend: Updated home.js to handle the long-press event and AJAX upload.
  • Templates: Refactored all *.html files to use {{ logo_path }} dynamic variable.

Related Issue

N/A (Feature Request)

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

🔍 Docker image security scan completed successfully!

No critical vulnerabilities found

Image scanned: docker.io/4fastbi/data-platform-ui-core:pr-5

The scan checked for:

  • Container image vulnerabilities
  • OS package vulnerabilities
  • Application dependencies in the final image

1 similar comment
@github-actions
Copy link

🔍 Docker image security scan completed successfully!

No critical vulnerabilities found

Image scanned: docker.io/4fastbi/data-platform-ui-core:pr-5

The scan checked for:

  • Container image vulnerabilities
  • OS package vulnerabilities
  • Application dependencies in the final image

@GedasKr GedasKr merged commit ee75033 into master Nov 20, 2025
2 checks passed
@GedasKr GedasKr deleted the PD_251120_GKFIX branch November 20, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants