Skip to content

👷 Add ty to precommit#2227

Open
svlandeg wants to merge 8 commits intofastapi:masterfrom
svlandeg:feat/ty
Open

👷 Add ty to precommit#2227
svlandeg wants to merge 8 commits intofastapi:masterfrom
svlandeg:feat/ty

Conversation

@svlandeg
Copy link
Member

@svlandeg svlandeg commented Mar 10, 2026

  • Add ty to pyproject, lint.sh & precommit
  • Added some type fixes to make ty happy
  • Includes a bug fix (I think) ? cf separate review comment 👇

@svlandeg svlandeg marked this pull request as draft March 10, 2026 11:09
def downgrade():
# ### commands auto generated by Alembic - please adjust! ###
op.drop_constraint(None, 'item', type_='foreignkey')
op.drop_constraint('item_owner_id_fkey', 'item', type_='foreignkey')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little confused about this one, as drop_constraint requires a str constraint name. Not sure why it was None before and I don't see how it would have worked. Feels like this is an actual bug fix? 🤔

run: bun ci
- name: Download blob reports from GitHub Actions Artifacts
uses: actions/download-artifact@v8
uses: actions/download-artifact@v7
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in this PR, but the download action was flaky, as you can see in the logs for this PR. Not sure what's going on, but switching back to v7 seems to have fixed things for now.

@svlandeg svlandeg requested a review from alejsdev March 10, 2026 15:01
@svlandeg svlandeg marked this pull request as ready for review March 10, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant