Skip to content

Conversation

@Gopesh111
Copy link

Fixes incorrect visible text handling when rendering Rich-styled strings.

Previously, rich_render_text relied on console.render(), which could lead to
incorrect handling of styled or Unicode text. This change uses Rich's
Text.from_markup() to extract the correct visible representation.

Includes a test covering styled text with emoji.

@Gopesh111
Copy link
Author

Thanks for taking the time to review this.

After further investigation and CI feedback, I realized that this change affects
existing rendering behavior more broadly than intended. To avoid introducing
unexpected side effects, I’m going to close this PR and revisit the approach later.

Thanks for the project and for the guidance.

@Gopesh111 Gopesh111 closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant