Optimization to building OPAL Class Hierarchies #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashkboos
approved these changes
Sep 15, 2022
…tial call graph construction
ashkboos
reviewed
Sep 16, 2022
...avacg-opal/src/main/java/eu/fasten/analyzer/javacgopal/data/analysis/OPALClassHierarchy.java
Outdated
Show resolved
Hide resolved
|
@ashkboos, thanks a lot, Mehdi, for the contribution and help with the optimization of OPAL data structures. |
|
@ashkboos |
To me it's fine. Unless Sebastian also wants to take a look. |
|
I would like to request a review from @proksch as he recently refactored |
|
What is the status of this PR? Do we still want to merge it? |
|
Hi Magiel,
We can still merge this PR, though it's not necessary. We made some
improvements to class hierarchy construction to speed up experiments for
research work.
…On Tue, Feb 21, 2023, 11:58 MagielBruntink ***@***.***> wrote:
What is the status of this PR? Do we still want to merge it?
—
Reply to this email directly, view it on GitHub
<#490 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEGEBVZHKWOVP76NG3ZUODWYR7UZANCNFSM6AAAAAAQNJRZHY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small PR that makes the following changes:
asURIHierarchyParallel()to create Fasten URIs in parallel. The speed up is 2 times, especially for large graphs.createGraphWithExternalCHAfaster by using parallel stream.Overall, the speed up is up to 2-3x times.
Motivation and context
When creating (very large) partial call graphs, building FURI hierarchies can be very time-consuming if it's done in single-thread mode.
Testing
Unit tests pass for the OPAL plugin.