Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract jooq from core to make it easier to reuse in other projects #511

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

proksch
Copy link
Contributor

@proksch proksch commented Sep 5, 2023

I have introduced several minor changes to make it easier to connect to the metadata DB from other projects without relying on core (which introduces a gazillion of transitive dependencies).

  • Factor out the generated jooq code to a new module core-metadata
  • Migrated the previously generated code to the core-metadata module, add core-metadata as a dependency to core
  • Updated the jooq and postgres dependencies in core-metadata (apart from updates to the version literal in the generated code, the code did not change).

The PR also contains two minor, unrelated changes:

  • Disable a test in the project that failed due to the non-availability of lima.ewi.tudelft.nl
  • Remove the three failing workflows that were related to licensing

Copy link
Contributor

@ashkboos ashkboos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@proksch proksch merged commit 92bc405 into develop Sep 7, 2023
2 checks passed
@proksch proksch deleted the seb/extract-jooq branch September 7, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants