Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): use void as csrfProtection's return type #159

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

ojeytonwilliams
Copy link
Contributor

Checklist

Using any as the return type for csrfProtection made it incompatible with addHook, because csrfProtection was interpreted as an async hook with 3 params, which is not allowed.

Instead void seems like the appropriate return type because the function is only invoked for its side-effects.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit d8fe873 into fastify:master Jul 11, 2024
14 checks passed
@ojeytonwilliams ojeytonwilliams deleted the fix/add-hook branch July 11, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants