fix: migrate from jest to node test and c8 #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climba03003
requested changes
Aug 5, 2024
dancastillo
force-pushed
the
migrate-node-test-c8
branch
2 times, most recently
from
b19ffb3
to
8c7b81b
Compare
|
You'll need to bump the minimum node.js version. You can do so by increasing the action version to v5 in fastify-passport/.github/workflows/ci.yml Line 20 in 53bb3b7 |
climba03003
requested changes
Aug 7, 2024
climba03003
requested changes
Aug 7, 2024
climba03003
reviewed
Aug 7, 2024
gurgunday
approved these changes
Aug 10, 2024
dancastillo
force-pushed
the
migrate-node-test-c8
branch
from
bd3361a
to
62bda9f
Compare
dancastillo
force-pushed
the
migrate-node-test-c8
branch
from
62bda9f
to
7bb7349
Compare
|
hey @climba03003 I updated based on your comments could you ptal? |
climba03003
approved these changes
Sep 1, 2024
gurgunday
approved these changes
Sep 1, 2024
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This PR adds borp and removes jest
Closes #1157
npm run testandnpm run benchmarkand the Code of conduct