refactor: prefix unused params with underscores (#452)

benchmark/express.js

@@ -7,7 +7,7 @@ const app = express()
 
 app.set('view engine', 'ejs')
 
-app.get('/', (req, res) => {
+app.get('/', (_req, res) => {
   res.render('../../templates/index.ejs', { text: 'text' })
 })
 

benchmark/fastify-art.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { 'art-template': require('art-template') },
-  route: (req, reply) => { reply.view('index.art', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.art', { text: 'text' }) }
 })

benchmark/fastify-dot.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { dot: require('dot') },
-  route: (req, reply) => { reply.view('testdot', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('testdot', { text: 'text' }) }
 })

benchmark/fastify-ejs-async.js

@@ -2,6 +2,6 @@
 
 require('./setup.js')({
   engine: { ejs: require('ejs') },
-  route: (req, reply) => { reply.view('ejs-async.ejs', { text: 'text' }) },
+  route: (_req, reply) => { reply.view('ejs-async.ejs', { text: 'text' }) },
   options: { async: true }
 })

benchmark/fastify-ejs-global-layout.js

@@ -2,7 +2,7 @@
 
 require('./setup.js')({
   engine: { ejs: require('ejs') },
-  route: (req, reply) => { reply.view('index-for-layout.ejs', { text: 'text' }) },
+  route: (_req, reply) => { reply.view('index-for-layout.ejs', { text: 'text' }) },
   pluginOptions: {
     layout: 'layout.html'
   }

benchmark/fastify-ejs-local-layout.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { ejs: require('ejs') },
-  route: (req, reply) => { reply.view('index-for-layout.ejs', { text: 'text' }, { layout: 'layout.html' }) }
+  route: (_req, reply) => { reply.view('index-for-layout.ejs', { text: 'text' }, { layout: 'layout.html' }) }
 })

benchmark/fastify-ejs-minify.js

@@ -2,7 +2,7 @@
 
 require('./setup.js')({
   engine: { ejs: require('ejs') },
-  route: (req, reply) => { reply.view('index.ejs', { text: 'text' }) },
+  route: (_req, reply) => { reply.view('index.ejs', { text: 'text' }) },
   options: {
     useHtmlMinifier: require('html-minifier-terser'),
     htmlMinifierOptions: {

benchmark/fastify-eta.js

@@ -5,5 +5,5 @@ const eta = new Eta()
 
 require('./setup.js')({
   engine: { eta },
-  route: (req, reply) => { reply.view('index.eta', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.eta', { text: 'text' }) }
 })

benchmark/fastify-handlebars.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { handlebars: require('handlebars') },
-  route: (req, reply) => { reply.view('index.html', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.html', { text: 'text' }) }
 })

benchmark/fastify-liquid.js

@@ -5,5 +5,5 @@ const liquid = new Liquid()
 
 require('./setup.js')({
   engine: { liquid },
-  route: (req, reply) => { reply.view('index.liquid', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.liquid', { text: 'text' }) }
 })

benchmark/fastify-mustache.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { mustache: require('mustache') },
-  route: (req, reply) => { reply.view('index.html', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.html', { text: 'text' }) }
 })

benchmark/fastify-nunjucks.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { nunjucks: require('nunjucks') },
-  route: (req, reply) => { reply.view('index.njk', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.njk', { text: 'text' }) }
 })

benchmark/fastify-pug.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { pug: require('pug') },
-  route: (req, reply) => { reply.view('index.pug', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.pug', { text: 'text' }) }
 })

benchmark/fastify-twig.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { twig: require('twig') },
-  route: (req, reply) => { reply.view('index.twig', { title: 'fastify', text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.twig', { title: 'fastify', text: 'text' }) }
 })

benchmark/fastify-viewAsync.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { ejs: require('ejs') },
-  route: (req, reply) => { return reply.viewAsync('index.ejs', { text: 'text' }) }
+  route: (_req, reply) => { return reply.viewAsync('index.ejs', { text: 'text' }) }
 })

benchmark/fastify.js

@@ -2,5 +2,5 @@
 
 require('./setup.js')({
   engine: { ejs: require('ejs') },
-  route: (req, reply) => { reply.view('index.ejs', { text: 'text' }) }
+  route: (_req, reply) => { reply.view('index.ejs', { text: 'text' }) }
 })

examples/example-async.js

@@ -20,7 +20,7 @@ async function something () {
   return new Date()
 }
 
-fastify.get('/', async (req, reply) => {
+fastify.get('/', async (_req, reply) => {
   const t = await something()
   return reply.view('/index.njk', { text: t })
 })

examples/example-ejs-with-some-options.js

@@ -22,20 +22,20 @@ fastify.register(require('..'), {
   charset: 'utf-8' // sample usage, but specifying the same value already used as default
 })
 
-fastify.get('/', (req, reply) => {
+fastify.get('/', (_req, reply) => {
   // reply.type('text/html; charset=utf-8').view('index-linking-other-pages', data)  // sample for specifying with type
   reply.view('index-linking-other-pages', data)
 })
 
-fastify.get('/include-test', (req, reply) => {
+fastify.get('/include-test', (_req, reply) => {
   reply.view('index-with-includes', data)
 })
 
-fastify.get('/include-one-include-missing-test', (req, reply) => {
+fastify.get('/include-one-include-missing-test', (_req, reply) => {
   reply.view('index-with-includes-one-missing', data)
 })
 
-fastify.get('/include-one-attribute-missing-test', (req, reply) => {
+fastify.get('/include-one-attribute-missing-test', (_req, reply) => {
   reply.view('index-with-includes-and-attribute-missing', data)
 })
 

examples/example.js

@@ -8,7 +8,7 @@ fastify.register(require('..'), {
   }
 })
 
-fastify.get('/', (req, reply) => {
+fastify.get('/', (_req, reply) => {
   reply.view('/templates/index.ejs', { text: 'text' })
 })
 

index.js

@@ -125,7 +125,7 @@ async function fastifyView (fastify, opts) {
     return result
   }
 
-  function viewDecorator (page) {
+  function viewDecorator () {
     const args = Array.from(arguments)
 
     let done
@@ -165,7 +165,7 @@ async function fastifyView (fastify, opts) {
   if (!fastify.hasReplyDecorator('locals')) {
     fastify.decorateReply('locals', null)
 
-    fastify.addHook('onRequest', (req, reply, done) => {
+    fastify.addHook('onRequest', (_req, reply, done) => {
       reply.locals = {}
       done()
     })
@@ -302,7 +302,7 @@ async function fastifyView (fastify, opts) {
     return compiledPage
   }
 
-  function readCallback (page, data, localOptions, html) {
+  function readCallback (page, _data, localOptions, html) {
     globalOptions.filename = join(templatesDir, page)
     return readCallbackParser(page, html, localOptions)
   }
@@ -512,7 +512,7 @@ async function fastifyView (fastify, opts) {
     return html
   }
 
-  async function viewTwig (page, data, opts) {
+  async function viewTwig (page, data) {
     data = Object.assign({}, defaultCtx, globalOptions, this.locals, data)
     let render
     if (typeof page === 'string') {
@@ -663,7 +663,7 @@ async function fastifyView (fastify, opts) {
     try {
       accessSync(join(templatesDir, getPage(fileName, ext)))
       result = true
-    } catch (e) {
+    } catch {
       result = false
     }
 

test/helper.js

@@ -42,7 +42,7 @@ module.exports.dotHtmlMinifierTests = function (t, compileOptions, withMinifierO
       }
     })
 
-    fastify.get('/', (req, reply) => {
+    fastify.get('/', (_req, reply) => {
       reply.view('testdot', data)
     })
 
@@ -79,7 +79,7 @@ module.exports.dotHtmlMinifierTests = function (t, compileOptions, withMinifierO
       }
     })
 
-    fastify.get('/test', (req, reply) => {
+    fastify.get('/test', (_req, reply) => {
       reply.view('testdot', data)
     })
 
@@ -122,7 +122,7 @@ module.exports.etaHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/', (req, reply) => {
+    fastify.get('/', (_req, reply) => {
       reply.view('templates/index.eta', data)
     })
 
@@ -158,7 +158,7 @@ module.exports.etaHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/', (req, reply) => {
+    fastify.get('/', (_req, reply) => {
       reply.view('templates/index.eta', data)
     })
 
@@ -193,7 +193,7 @@ module.exports.etaHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/test', (req, reply) => {
+    fastify.get('/test', (_req, reply) => {
       reply.view('templates/index.eta', data)
     })
 
@@ -264,7 +264,7 @@ module.exports.liquidHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/', (req, reply) => {
+    fastify.get('/', (_req, reply) => {
       reply.view('./templates/index.liquid', data)
     })
 
@@ -304,7 +304,7 @@ module.exports.liquidHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/test', (req, reply) => {
+    fastify.get('/test', (_req, reply) => {
       reply.view('./templates/index.liquid', data)
     })
 
@@ -349,7 +349,7 @@ module.exports.nunjucksHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/', (req, reply) => {
+    fastify.get('/', (_req, reply) => {
       reply.view('./index.njk', data)
     })
 
@@ -386,7 +386,7 @@ module.exports.nunjucksHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/test', (req, reply) => {
+    fastify.get('/test', (_req, reply) => {
       reply.view('./index.njk', data)
     })
 
@@ -427,7 +427,7 @@ module.exports.pugHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/', (req, reply) => {
+    fastify.get('/', (_req, reply) => {
       reply.view('./templates/index.pug', data)
     })
 
@@ -462,7 +462,7 @@ module.exports.pugHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/test', (req, reply) => {
+    fastify.get('/test', (_req, reply) => {
       reply.view('./templates/index.pug', data)
     })
 
@@ -502,7 +502,7 @@ module.exports.twigHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/', (req, reply) => {
+    fastify.get('/', (_req, reply) => {
       reply.view('./templates/index.twig', data)
     })
 
@@ -540,7 +540,7 @@ module.exports.twigHtmlMinifierTests = function (t, withMinifierOptions) {
       }
     })
 
-    fastify.get('/test', (req, reply) => {
+    fastify.get('/test', (_req, reply) => {
       reply.view('./templates/index.twig', data)
     })
 

test/snap/test-ejs-with-snapshot.js

@@ -27,7 +27,7 @@ test('reply.view with ejs engine, template folder specified, include files (ejs
     options
   })
 
-  fastify.get('/', (req, reply) => {
+  fastify.get('/', (_req, reply) => {
     reply.type('text/html; charset=utf-8').view('index-linking-other-pages', data) // sample for specifying with type
   })
 
@@ -71,7 +71,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
     options
   })
 
-  fastify.get('/', (req, reply) => {
+  fastify.get('/', (_req, reply) => {
     reply.type('text/html; charset=utf-8').view('index', data)
   })
 
@@ -115,7 +115,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
     options
   })
 
-  fastify.get('/include-test', (req, reply) => {
+  fastify.get('/include-test', (_req, reply) => {
     reply.type('text/html; charset=utf-8').view('index-with-includes', data)
   })
 
@@ -159,7 +159,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
     options
   })
 
-  fastify.get('/include-one-include-missing-test', (req, reply) => {
+  fastify.get('/include-one-include-missing-test', (_req, reply) => {
     reply.type('text/html; charset=utf-8').view('index-with-includes-one-missing', data)
   })
 
@@ -203,7 +203,7 @@ test('reply.view with ejs engine, templates with folder specified, include files
     options
   })
 
-  fastify.get('/include-one-attribute-missing-test', (req, reply) => {
+  fastify.get('/include-one-attribute-missing-test', (_req, reply) => {
     reply.type('text/html; charset=utf-8').view('index-with-includes-and-attribute-missing', data)
   })