all tests pass

fastlmm · Jan 1, 2024 · dcde21e · dcde21e
1 parent 5cc2655
commit dcde21e
Show file tree

Hide file tree

Showing 2 changed files with 664 additions and 1,592 deletions.
diff --git a/bed_reader/_open_bed.py b/bed_reader/_open_bed.py
@@ -210,14 +210,17 @@ class open_bed:
     def __init__(
         self,
         location: Union[str, Path, UrlParseResult],
+        # cmk must also accept old value
         iid_count: Optional[int] = None,
         sid_count: Optional[int] = None,
         properties: Mapping[str, List[Any]] = {},
         count_A1: bool = True,
         num_threads: Optional[int] = None,
         skip_format_check: bool = False,
         fam_location: Union[str, Path, UrlParseResult] = None,
+        # cmk must also accept old value
         bim_location: Union[str, Path, UrlParseResult] = None,
+        # cmk must also accept old value
     ):
         # cmk need to read the .fam and .bim files and check file from cloud if requested
         self.location = self._path_or_url(location)
@@ -426,7 +429,7 @@ def read(
             self._sid_range[sid_index_or_slice_etc], dtype="intp"
         )
 
-        if not force_python_only:
+        if not force_python_only or open_bed._is_url(self.location):
             num_threads = get_num_threads(
                 self._num_threads if num_threads is None else num_threads
             )