Refactor metrics processing #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting metrics was tightly coupled with the gathering of the data. This made it difficult to change the logic without a significant amount of code changes. By splitting the setting of the metrics into its own function, we can change the high level logic without having to move hundreds of lines around. Co-authored-by: Lukas Eklund <leklund@gmail.com> Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
|
@leklund Splitting out the |
leklund
approved these changes
May 27, 2024
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting metrics was tightly coupled with the gathering of the data. This made it difficult to change the logic without a significant amount of code changes.
By splitting the setting of the metrics into its own function, we can change the high level logic without having to move hundreds of lines around.