Skip to content

exempt service call from using json #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
btsheehy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

exempt service call from using json #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cbc7c8
exempt service call from using json
btsheehy Feb 3, 2026
fc95d21
updated tests to account for service list json change
btsheehy Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/mcp/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func resolveServiceReferences(flags []Flag) []Flag {

func applySmartDefaults(cmd string, args []string, flags []Flag) []Flag {
// Add JSON output for list commands if not specified
if len(args) > 0 && args[0] == "list" && !hasFlag(flags, "json") {
if len(args) > 0 && args[0] == "list" && cmd != "service" && !hasFlag(flags, "json") {
if globalContext.PreferredFormat == "json" || globalContext.PreferredFormat == "" {
flags = append(flags, Flag{Name: "json", Value: ""})
}
Expand Down
15 changes: 13 additions & 2 deletions internal/mcp/context_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,8 @@ func TestApplySmartDefaults(t *testing.T) {
},
},
{
name: "adds json flag for list commands",
cmd: "service",
name: "adds json flag for non-service list commands",
cmd: "kv-store",
args: []string{"list"},
inputFlags: []Flag{},
checkFunc: func(t *testing.T, flags []Flag) {
Expand All @@ -326,6 +326,17 @@ func TestApplySmartDefaults(t *testing.T) {
}
},
},
{
name: "does not add json flag for service list commands",
cmd: "service",
args: []string{"list"},
inputFlags: []Flag{},
checkFunc: func(t *testing.T, flags []Flag) {
if hasFlag(flags, "json") {
t.Error("Expected json flag not to be added for service list command")
}
},
},
}

for _, tt := range tests {
Expand Down