Conversation
jkarneges
force-pushed
the
jkarneges/write-all
branch
from
fe9cfce to
7c35431
Compare
jkarneges
force-pushed
the
jkarneges/write-all
branch
from
7c35431 to
a167783
Compare
deg4uss3r
approved these changes
Feb 11, 2026
deg4uss3r
reviewed
Feb 11, 2026
| @@ -464,7 +508,11 @@ mod tests { | |||
| } | |||
|
|
|||
| fn is_writable(&self) -> bool { | |||
Collaborator
There was a problem hiding this comment.
So just to double check logic expectations here, any integer that is not 0 and a None means we can write to the buffer?
Member
Author
There was a problem hiding this comment.
Yeah. This is in the test code, and I wanted a way to optionally restrict writes in the added test. So all the other tests leave it default None, meaning no restrictions, but the added test sets specific limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll use this to write log messages to a socket.
I think this might be the first time I've used
async fnin a trait, and apparently the feature has a lint due toSendbound ambiguity which I've allowed since this isn't a library.