Bridge STT type gaps: surface C++ perf fields in Rust structs#4115
Merged
Bridge STT type gaps: surface C++ perf fields in Rust structs#4115
Conversation
Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge STT type gaps: surface C++ perf fields in Rust structs
Summary
The cactus C++ FFI layer already emits performance/diagnostics fields in its JSON responses (
time_to_first_token_ms,decode_tps,ram_usage_mb, token counts, etc.), but the RustTranscriptionResult(batch) andStreamResult(streaming) structs were silently discarding them during deserialization.This PR adds the missing fields to both structs so they're available to consumers. All new fields use
#[serde(default)], so this is fully backwards-compatible — existing JSON without these fields will deserialize with zero-values.No downstream consumers are changed yet; this just makes the data available.
Review & Testing Checklist for Human
u64vsf64for token counts:TranscriptionResultusesu64forprefill_tokens/decode_tokens/total_tokens(C++ writes them as integers), whileStreamResultusesf64(C++build_stream_responseround-trips them throughjson_number()which returnsdouble). Confirm this matches what each C++ path actually emits in practice — a real transcription run would settle this.Notes