feat-improve-link-extension-behavior#4166
Open
ComputelessComputer wants to merge 2 commits intomainfrom
Open
Conversation
Make Link extension non-inclusive to prevent text typed after links from being linkified automatically. Refactor click handler logic to use early returns for better readability and ensure proper event handling for both modifier and non-modifier clicks on link elements.
Remove inclusive override and add link boundary guard plugin to prevent link marks from extending beyond actual URL text. Include parent plugins to maintain extension functionality. Guard ensures link marks only apply to URL portion when text contains additional content.
✅ Deploy Preview for hyprnote-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Made Link extension non-inclusive to prevent automatic linkification of text typed after links
• Refactored click handler logic with early returns for improved readability
• Enhanced event handling for both modifier and non-modifier clicks on link elements
• Added link boundary guard plugin to prevent link marks from extending beyond URL text
• Ensured link marks only apply to URL portion when text contains additional content