refactor: extract listener-core as standalone crate#4172
Merged
Conversation
Move actor logic out of the Tauri plugin into a platform-agnostic `listener-core` crate, enabling reuse without Tauri dependencies. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote canceled.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| continue; | ||
| } | ||
|
|
||
| let name = path.file_name()?.to_str()?; |
There was a problem hiding this comment.
Early return from ? aborts directory search prematurely
Low Severity
In find_session_dir_recursive, the ? operator on path.file_name()?.to_str()? inside the for loop will short-circuit and return None from the entire function if any directory entry has a non-UTF-8 name, rather than just skipping that entry. This causes the search to abort prematurely, and the caller falls back to the default path, potentially missing the real session directory. Using a let-else with continue would correctly skip the problematic entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
plugins/listenerTauri plugin into a new platform-agnosticcrates/listener-corecratelistener-corerather than owning the implementationcliexample inlistener-corefor testing the core logic without TauriMotivation
Decoupling the core listener logic from the Tauri plugin layer makes it easier to test, reuse, and develop independently of the desktop app runtime.
Made with Cursor